[Webkit-unassigned] [Bug 186429] Send display link IPC message from display link thread.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 8 10:02:41 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=186429

Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ggaren at apple.com
 Attachment #342280|review?                     |review+
              Flags|                            |

--- Comment #7 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 342280
  --> https://bugs.webkit.org/attachment.cgi?id=342280
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342280&action=review

r=me

> Source/WebKit/UIProcess/mac/DisplayLink.cpp:37
> -    
> +

Please revert this whitespace change to keep svn history nice.

> Source/WebKit/UIProcess/mac/DisplayLink.cpp:102
> +    DisplayLink* displayLink = reinterpret_cast<DisplayLink*>(data);

This can be static_cast. It's slightly better to static_cast because the compiler still enforces that you're not doing something weirder like turning a float or an int or a CVTimeStamp* into a DisplayLink*.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180608/5d0f3fee/attachment.html>


More information about the webkit-unassigned mailing list