[Webkit-unassigned] [Bug 186192] [GTK][WPE] Add API to run javascript from a WebKitWebView in an isolated world

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186192

--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to youenn fablet from comment #11)
> Comment on attachment 341754 [details]
> Patch
> 
> Patch looks good to me.

Thanks youenn!

> Could you detail a little bit more the use case for adding this new
> capability?

Yes, in epiphany we expose some custom js code in the web process, using an isolated world, so that the internal js is not available from the web. But we still need to use that internal js from the UI process via webkit_eeb_view_run_javascript().

> View in context:
> https://bugs.webkit.org/attachment.cgi?id=341754&action=review
> 
> > Source/WebKit/WebProcess/WebPage/WebPage.cpp:2958
> > +void WebPage::runJavaScriptInMainFrameScriptWorld(const String& script, bool forceUserGesture, const String& worldName, CallbackID callbackID)
> 
> This code looks somewhat similar to WebPage::runJavaScriptInMainFrame.
> Maybe we can do some refactoring to share more code.

Yes, I thought about it, indeed, but I thought it could end up being more complex in the end. I'll give it another try.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180608/96a6e9f2/attachment.html>