[Webkit-unassigned] [Bug 186151] [Datalist] Allow TextFieldInputType to show and hide suggestions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 7 10:34:06 PDT 2018


--- Comment #7 from Aditya Keerthi <akeerthi at apple.com> ---
(In reply to Wenson Hsieh from comment #6)
> Comment on attachment 341977 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=341977&action=review
> > Source/WebCore/html/TextFieldInputType.cpp:822
> > +    m_suggestionPicker = nullptr;
> This seems to be the only place we null out m_suggestionPicker, and it looks
> like the plan is for this to be invoked after an IPC message from the UI
> process? Should we be clearing this out from more places, e.g. when the
> element loses focus? Though, it looks like the next patch in the sequence
> will answer my questions :)
> Just keep this in mind!

The next patch handles all of the clean up after the picker disappears :)

> > Source/WebKit/WebProcess/WebCoreSupport/WebDataListSuggestionPicker.h:52
> > +    __unused WebCore::DataListSuggestionsClient* m_dataListSuggestionsClient;
> I assume these __unused are going to be short-lived? (i.e. the next patch
> will use m_page and m_dataListSuggestionsClient).

These will be used in the next patch.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180607/80b0cf8b/attachment.html>

More information about the webkit-unassigned mailing list