[Webkit-unassigned] [Bug 185787] [GTK][WPE] Start implementing MediaStream API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185787

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342085|0                           |1
        is obsolete|                            |
 Attachment #342160|                            |review?, commit-queue?
              Flags|                            |

--- Comment #6 from Thibault Saunier <tsaunier at gnome.org> ---
Created attachment 342160

  --> https://bugs.webkit.org/attachment.cgi?id=342160&action=review

Addressed comments.

(In reply to Philippe Normand from comment #5)
> Comment on attachment 342085 [details]
> [GTK][WPE]: Implement MediaStream API
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=342085&action=review
> 
> Ok I think this is almost ready to land. Is this patch supposed to apply on
> trunk? The EWS fails.

Now that the GstStreamCollection management rework landed, it should apply.

> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:55
> > +#include "gstreamer/GStreamerMediaStreamSource.h"
> 
> No prefix please ;)

Sorry, FIXED.

> > Source/WebCore/platform/mediastream/gstreamer/GStreamerCapturer.cpp:177
> > +    GST_INFO_OBJECT((gpointer) pipeline(), "Going to PLAYING!");
> 
> This cast is really needed?

No, removed.

> > Source/WebCore/platform/mediastream/gstreamer/GStreamerCapturer.cpp:186
> > +    GST_INFO_OBJECT((gpointer) pipeline(), "Tearing down!");
> 
> Ditto

Ditto.

> > Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:302
> > +    GstElementClass* gstelement_klass = (GstElementClass*)klass;
> 
> Use GST_ELEMENT_CLASS(klass)
> 
> > Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:356
> > +        (GstPadChainFunction)webkitMediaStreamSrcChain);
> 
> You'll think I'm obsessed with casts ;)

Fixed. I went over all code manually and tried to fix them all, hopefully I didn't miss
any, but that C macro synthax is hard to detect! (no way to grep it seems).

> > Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:358
> > +    g_assert(gst_element_add_pad(GST_ELEMENT(self), (GstPad*)ghostpad));
> 
> GST_PAD_CAST() :)
> Also please use ASSERT instead of g_assert

Done. Removed all occurences of g_assrt.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180607/0f0f025a/attachment.html>