[Webkit-unassigned] [Bug 186345] [WPE] Add a MiniBrowser and use it to run WebDriver tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186345

Zan Dobersek <zan at falconsigh.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zan at falconsigh.net

--- Comment #6 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 342043
  --> https://bugs.webkit.org/attachment.cgi?id=342043
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342043&action=review

>>> Source/cmake/OptionsWPE.cmake:115
>>> +  find_package(EGL)
>>> +  find_package(OpenGLES2)
>> 
>> I don't understand, why are these not required? Surely it's not going to link successfully without them? I would expect some code to handle the case where they're missing if not marked as REQUIRED.
> 
> Me neither, but I got a lot of linking errors without them. I'll mark them as REQUIRED.

Just use epoxy.

> Source/cmake/OptionsWPE.cmake:122
> +if (ENABLE_MINIBROWSER)
> +  find_package(EGL)
> +  find_package(OpenGLES2)
> +  find_package(Wayland REQUIRED)
> +  find_package(WaylandProtocols 1.12 REQUIRED)
> +  if (NOT WAYLAND_PROTOCOLS_FOUND)
> +      message(FATAL_ERROR "WaylandProtocols is required to enabled WPE MiniBrowser.")
> +  endif ()
> +endif ()
> +

You can search for all this in Tools/MiniBrowser/wpe/CMakeLists.txt.

>>> Tools/MiniBrowser/wpe/CMakeLists.txt:7
>>> +    ${DERIVED_SOURCES_MINIBROWSER_DIR}/xdg-shell-unstable-v6-protocol.c
>> 
>> Hm, xdg-shell is stable now, do you know how hard it would be to switch to the stable version of the protocol? Probably not much? This will start crashing once compositors drop support for v6.
> 
> No idea, this is what dyz uses, I'll try to use the stable version then.

Go with the stable version, but I think it's simpler to copy in the protocol implementation file and the client header, instead of having to wrangle with wayland-protocols to get those two generated on-the-fly.

> Tools/MiniBrowser/wpe/main.cpp:59
> +class FdoBackend final : public WlGlue::WindowClient {

This, along with the WlGlue logic, would IMO fit better under Tools/wpe, alongside HeadlessViewBackend.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180607/ea82bea9/attachment.html>