[Webkit-unassigned] [Bug 186349] Don't start service worker fetch when there is substitute data

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 6 08:40:34 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=186349

--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 342046
  --> https://bugs.webkit.org/attachment.cgi?id=342046
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342046&action=review

> Source/WebCore/ChangeLog:10
> +        This breaks DocumentWriter assumptions.

This is an edge case but could we try writing an API test for that?
Something like:
- Load a first content that would register the service worker
- Call WKWebView.loadData on an URL that should be controlled by the service worker
- Ensure that the newly loaded page is controlled by the service worker

See Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm for some existing SW API tests.

> Source/WebCore/loader/DocumentLoader.cpp:1739
> +            loadMainResource(WTFMove(request));

WPE/GTK are usually not happy if removing 'this'.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180606/1eb55648/attachment-0001.html>


More information about the webkit-unassigned mailing list