[Webkit-unassigned] [Bug 186062] CommitSet range bisector should use commits occur in commit sets which specify the range as valid commits for commits without ordering.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186062

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342028|review?                     |review+
              Flags|                            |

--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 342028
  --> https://bugs.webkit.org/attachment.cgi?id=342028
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342028&action=review

r=me assuming you fix the comparator & add a unit test.

> Websites/perf.webkit.org/public/v3/commit-set-range-bisector.js:104
> +                return firstCommit.revision() < secondCommit.revision();

This can't be write. We need to be returning 0, -1, or 1.
Please add a test case which catches this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180606/0ce48300/attachment.html>