[Webkit-unassigned] [Bug 186283] Temporarily Skip JSC stress test failures that are consistently occurring

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 5 12:33:13 PDT 2018


--- Comment #5 from Mark Lam <mark.lam at apple.com> ---
(In reply to Ryan Haddad from comment #4)
> Comment on attachment 341981 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=341981&action=review
> > JSTests/executableAllocationFuzz.yaml:26
> > +      if ($hostOS == "windows" || $architecture == "x86")
> I believe this should be "i386", not "x86".

Not true.  The $architecture value is determined by Tools/Scripts/run-jsc-stress-tests.  According to run-jsc-stress-tests, "x86" is distinct from "x86_64", and is used to represent 32-bit only.  For example, see the line:

$isFTLPlatform = !($architecture == "x86" || $architecture == "arm" || $architecture == "mips" || $hostOS == "windows")

... where the platform is considered to be not an FTL platform if $architecture is "x86" i.e. "x86" is 32-bit only.  There's also no code in run-jsc-stress-tests that sets $architecture to "i386".

"x86" is the right value to test against for 32-bit x86 architecture.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180605/32253319/attachment.html>

More information about the webkit-unassigned mailing list