[Webkit-unassigned] [Bug 186244] New: REGRESSION(r232338): [GTK] Broke two layout tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186244

            Bug ID: 186244
           Summary: REGRESSION(r232338): [GTK] Broke two layout tests
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com
                CC: bugs-noreply at webkitgtk.org, cadubentzen at gmail.com

r232338 broke a bunch of layout tests, which in retrospect was probably predictable. The vast majority of the tests just needed updated expectations to handle the new text colors, which have in many places changed from black to dark grays. I'm handling that now.

But a couple of the tests appear genuinely problematic. I'm going to mark these as expected fails:

fast/css/read-only-read-write-webkit-user-modify.html
fast/dom/HTMLInputElement/checked-pseudo-selector.html

Both tests appear to be showcasing the same problem. I would focus on fast/dom/HTMLInputElement/checked-pseudo-selector.html, since it seems to be much simpler. In this test, the text is supposed to be green, but instead it is black.

Normally, I would roll out (revert) the offending commit, but in this case, since it's only two tests and it fixed a pretty serious bug, I'm not going to do that, at least not until I've found more problematic tests.

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/css/read-only-read-write-webkit-user-modify-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/css/read-only-read-write-webkit-user-modify-actual.txt
@@ -13,19 +13,19 @@
 PASS getComputedStyle(document.querySelectorAll("#test-block *")[3]).backgroundColor is "rgb(255, 0, 0)"
 PASS getComputedStyle(document.querySelectorAll("#test-block *")[4]).color is "rgb(0, 255, 0)"
 PASS getComputedStyle(document.querySelectorAll("#test-block *")[4]).backgroundColor is "rgb(255, 255, 255)"
-PASS getComputedStyle(document.querySelectorAll("#test-block *")[5]).color is "rgb(0, 255, 0)"
+FAIL getComputedStyle(document.querySelectorAll("#test-block *")[5]).color should be rgb(0, 255, 0). Was rgb(0, 0, 0).
 PASS getComputedStyle(document.querySelectorAll("#test-block *")[5]).backgroundColor is "rgb(255, 255, 255)"
-PASS getComputedStyle(document.querySelectorAll("#test-block *")[6]).color is "rgb(0, 0, 0)"
+FAIL getComputedStyle(document.querySelectorAll("#test-block *")[6]).color should be rgb(0, 0, 0). Was rgb(139, 142, 143).
 PASS getComputedStyle(document.querySelectorAll("#test-block *")[6]).backgroundColor is "rgb(255, 0, 0)"
 PASS getComputedStyle(document.querySelectorAll("#test-block *")[7]).color is "rgb(0, 0, 0)"
 PASS getComputedStyle(document.querySelectorAll("#test-block *")[7]).backgroundColor is "rgb(255, 0, 0)"
-PASS getComputedStyle(document.querySelectorAll("#test-block *")[8]).color is "rgb(0, 0, 0)"
+FAIL getComputedStyle(document.querySelectorAll("#test-block *")[8]).color should be rgb(0, 0, 0). Was rgb(139, 142, 143).
 PASS getComputedStyle(document.querySelectorAll("#test-block *")[8]).backgroundColor is "rgb(255, 0, 0)"
 PASS getComputedStyle(document.querySelectorAll("#test-block *")[9]).color is "rgb(0, 0, 0)"
 PASS getComputedStyle(document.querySelectorAll("#test-block *")[9]).backgroundColor is "rgb(255, 0, 0)"
 PASS getComputedStyle(document.querySelectorAll("#test-block *")[10]).color is "rgb(0, 255, 0)"
 PASS getComputedStyle(document.querySelectorAll("#test-block *")[10]).backgroundColor is "rgb(255, 255, 255)"
-PASS getComputedStyle(document.querySelectorAll("#test-block *")[11]).color is "rgb(0, 255, 0)"
+FAIL getComputedStyle(document.querySelectorAll("#test-block *")[11]).color should be rgb(0, 255, 0). Was rgb(0, 0, 0).
 PASS getComputedStyle(document.querySelectorAll("#test-block *")[11]).backgroundColor is "rgb(255, 255, 255)"
 PASS getComputedStyle(document.querySelectorAll("#test-block *")[12]).color is "rgb(0, 0, 0)"
 PASS getComputedStyle(document.querySelectorAll("#test-block *")[12]).backgroundColor is "rgb(255, 0, 0)"


--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/dom/HTMLInputElement/checked-pseudo-selector-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/dom/HTMLInputElement/checked-pseudo-selector-actual.txt
@@ -1,4 +1,4 @@
-PASS view.getComputedStyle(input1, '').getPropertyValue('color') is "rgb(0, 128, 0)"
+FAIL view.getComputedStyle(input1, '').getPropertyValue('color') should be rgb(0, 128, 0). Was rgb(0, 0, 0).
 PASS input1.checked is true
 PASS successfullyParsed is true

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180603/5f47911a/attachment.html>