[Webkit-unassigned] [Bug 186219] New: [GTK] Correct behavior for dark themes
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 1 19:22:42 PDT 2018
https://bugs.webkit.org/show_bug.cgi?id=186219
Bug ID: 186219
Summary: [GTK] Correct behavior for dark themes
Product: WebKit
Version: WebKit Nightly Build
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: WebKit Gtk
Assignee: webkit-unassigned at lists.webkit.org
Reporter: cadubentzen at gmail.com
CC: bugs-noreply at webkitgtk.org
Now that dark themes are working properly on text inputs after bug 126907, some issues that happen on Firefox can happen on WebKitGTK+ as well.
E.g. Say some website sets input[type=text] { background-color: "white" } and leave the color property alone. In dark themes it'll render a light text on a white background.
This issue can actually happen with any browser, just set input[type=text] { color: "white" } and you get white text on light background.
However, as many developers won't test their design in WebKitGTK+ with dark themes, it can be frequent to have pages with partial styling and then trouble in dark themes.
A few thoughts on this:
- As discussed on matrix with mcatanzaro (quote): Ideally we would have some way to say: "do not use GTK theme colors at all if any parent element has been styled". That might be quite hard to implement, though.
- Easy solution: stop using GTK for theming the web content or just stick to Adwaita light. Not so good for some distributions like Elementary that want to have their look and feel.
- Another possibility: adding a property in public API (UIProcess) to select the theme. So users could pick their theme of choice for the webview elements.
- Another: always switch to the light variant of the current theme. Not sure if this can be done reliably only with GTK calls or something would need to be hard-coded. It seems like in Firefox they use “gtk-application-prefer-dark-theme” but I get rendering issues with dark themes anyway.
Opinions on this would be highly appreciated to decide which path to pursue.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180602/57f2902b/attachment.html>
More information about the webkit-unassigned
mailing list