[Webkit-unassigned] [Bug 186216] New: ServiceOverlayController can hold references to Documents after you navigate away

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186216

            Bug ID: 186216
           Summary: ServiceOverlayController can hold references to
                    Documents after you navigate away
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: simon.fraser at apple.com

ServiceOverlayController::Highlight() has a Ref<Range>, and Range has a Ref<Document>.

When you change the selection in a view, ServiceOverlayController makes a “potential highlight” Highlight, which retains the Document. If you then navigate, there’s nothing that clears that Highlight, until the selection changes.

We need to either have ServiceOverlayController use weak refs, or clear its highlights on navigation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180602/c8c25f5f/attachment.html>