[Webkit-unassigned] [Bug 188124] [iOS] WKColorPicker's selection indicator doesn't always cover the selected swatch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188124

Wenson Hsieh <wenson_hsieh at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #346236|review?                     |review+
              Flags|                            |

--- Comment #11 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 346236
  --> https://bugs.webkit.org/attachment.cgi?id=346236
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346236&action=review

> Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.mm:225
> +        bool minXEqual = CGFAbs(CGRectGetMinX(frame) - CGRectGetMinX(colorPickerBounds)) < FLT_EPSILON;

Nit - we generally prefer using std::abs here, instead of the CG equivalent.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180801/8eee37bf/attachment-0001.html>