[Webkit-unassigned] [Bug 188124] [iOS] WKColorPicker's selection indicator doesn't always cover the selected swatch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188124

--- Comment #8 from Aditya Keerthi <akeerthi at apple.com> ---
(In reply to Wenson Hsieh from comment #6)
> Comment on attachment 346223 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=346223&action=review
> 
> > Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.mm:216
> > +    _selectedColorButton = colorButton;
> 
> This looks like it'll get called many times, for every tick of the pan
> gesture recognizer. Is it possible to bail here if the selected color button
> hasn't actually changed, or do we always need to do this work?

We can bail early. Also makes sense to not redraw the selection if the same button is tapped twice.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180801/13408792/attachment.html>