[Webkit-unassigned] [Bug 188124] [iOS] WKColorPicker's selection indicator doesn't always cover the selected swatch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188124

Wenson Hsieh <wenson_hsieh at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #346223|review?                     |review+
              Flags|                            |

--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 346223
  --> https://bugs.webkit.org/attachment.cgi?id=346223
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346223&action=review

> Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.mm:216
> +    _selectedColorButton = colorButton;

This looks like it'll get called many times, for every tick of the pan gesture recognizer. Is it possible to bail here if the selected color button hasn't actually changed, or do we always need to do this work?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180801/6f9b9a6e/attachment.html>