[Webkit-unassigned] [Bug 188124] [iOS] WKColorPicker's selection indicator doesn't always cover the selected swatch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 31 16:07:56 PDT 2018


Wenson Hsieh <wenson_hsieh at apple.com> changed:

           What    |Removed                     |Added
 Attachment #345957|commit-queue-               |
              Flags|                            |

--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 345957
  --> https://bugs.webkit.org/attachment.cgi?id=345957

View in context: https://bugs.webkit.org/attachment.cgi?id=345957&action=review

> Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.mm:271
> +    WKColorButton *colorButton = _selectedColorButton.get().get();

Nit - these two lines can just be `if ([_selectedColorButton superview] == matrixView)`

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180731/1ce3c813/attachment.html>

More information about the webkit-unassigned mailing list