[Webkit-unassigned] [Bug 188172] [WinCairo] <select> elements do not popup options

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188172

--- Comment #5 from Stephan Szabo <stephan.szabo at sony.com> ---
Comment on attachment 346069
  --> https://bugs.webkit.org/attachment.cgi?id=346069
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346069&action=review

>> Source/WebKit/UIProcess/win/WebPopupMenuProxyWin.cpp:221
>> +        shouldAnimate = FALSE;
> 
> You added this line. But, It seems for me that this line not needed. Does SystemParametersInfo change shouldAnimate if it fails?

This was added in the similar place in the legacy path after the non-legacy code was removed.
"[Win] Resolve various static analyzer warnings in WebCore."
https://github.sie.sony.com/WebCore/neko/commit/ca06693684d7a9bf69d7db2deb1c21ca823d6384#diff-d88e6bcdaacad433c28da98715f946d3

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180731/3f76464c/attachment.html>