[Webkit-unassigned] [Bug 185714] [GTK][WPE] Enable Intl API additions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 26 08:45:12 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=185714

Andy VanWagoner <andy at vanwagoner.family> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andy at vanwagoner.family

--- Comment #5 from Andy VanWagoner <andy at vanwagoner.family> ---
Because these are new web-visible APIs, I was told they need to be behind flags. There are some additional guards around ICU version like:

#define HAVE_ICU_FORMAT_DOUBLE_FOR_FIELDS (U_ICU_VERSION_MAJOR_NUM >= 59)
#define JSC_ICU_HAS_PLURALRULES_KEYWORDS (U_ICU_VERSION_MAJOR_NUM >= 59)
#define JSC_ICU_HAS_PLURALRULES_WITH_FORMAT (U_ICU_VERSION_MAJOR_NUM >= 59)

#if HAVE(ICU_FORMAT_DOUBLE_FOR_FIELDS)
#if JSC_ICU_HAS_PLURALRULES_KEYWORDS
#if JSC_ICU_HAS_PLURALRULES_WITH_FORMAT

Looking at them, the pluralrules ones should have been like the format_double one.
The default enabling looks like:

#if ENABLE(INTL_NUMBER_FORMAT_TO_PARTS) && (!PLATFORM(COCOA) || ENABLE(EXPERIMENTAL_FEATURES))
#if ENABLE(INTL_PLURAL_RULES) && (!PLATFORM(COCOA) || ENABLE(EXPERIMENTAL_FEATURES))

Because the additional guards are in place, I think GTK could enable the INTL_ flags. NumberFormat.formatToParts will only be available if compiled with newer ICU, and PluralRules will only work in basic use cases without newer ICU.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180726/dee4b6d3/attachment.html>


More information about the webkit-unassigned mailing list