[Webkit-unassigned] [Bug 187794] [Datalist][macOS] Display suggestions for input[type=color]

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187794

--- Comment #9 from Aditya Keerthi <akeerthi at apple.com> ---
(In reply to Tim Horton from comment #7)
> Comment on attachment 345697 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=345697&action=review
> 
> It has got to be possible to implement the other one in terms of this one,
> no? Just don’t love all the duplication, and also can see myself fixing one
> and not the other.

Removed the duplicated code. Also, Alex confirmed that we should keep both decode methods (one returning a bool and one returning an std::optional).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180724/fd81e5a7/attachment-0001.html>