[Webkit-unassigned] [Bug 187794] [Datalist][macOS] Display suggestions for input[type=color]

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187794

--- Comment #7 from Tim Horton <thorton at apple.com> ---
Comment on attachment 345697
  --> https://bugs.webkit.org/attachment.cgi?id=345697
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345697&action=review

> Source/WebCore/PAL/pal/spi/mac/NSColorWellSPI.h:34
> +#endif // PLATFORM(MAC)

Is it USE(APPKIT), or PLATFORM(MAC)???

> Source/WebCore/PAL/pal/spi/mac/NSPopoverColorWellSPI.h:52
> +#endif // PLATFORM(MAC)

Ditto

> Source/WebKit/Shared/WebCoreArgumentCoders.cpp:1520
> +    bool isExtended;

It has got to be possible to implement the other one in terms of this one, no? Just don’t love all the duplication, and also can see myself fixing one and not the other.

> Source/WebKit/UIProcess/mac/WebColorPickerMac.mm:148
> ++ (NSPopover *)_colorPopoverCreateIfNecessary:(BOOL)forceCreation {

Brace in the wrong place

> Source/WebKit/UIProcess/mac/WebColorPickerMac.mm:166
> +- (void)_showPopover {

Brace in the wrong place

> Source/WebKit/UIProcess/mac/WebColorPickerMac.mm:174
> +    if ([owner isKindOfClass:[NSPopoverColorWell class]])
> +        [owner deactivate];

What is this fragile-looking code for? Comments, maybe?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180724/d36b5d15/attachment-0001.html>