[Webkit-unassigned] [Bug 187871] [iOS] Add support for input[type=color]

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 23 10:46:41 PDT 2018


--- Comment #5 from Aditya Keerthi <akeerthi at apple.com> ---
(In reply to Tim Horton from comment #4)
> Comment on attachment 345486 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=345486&action=review
> > Source/WebKit/UIProcess/ios/forms/WKFormColorControl.h:33
> > +- (instancetype)initWithView:(WKContentView *)view;
> Can this just be a UIView? It’s kind of weird to spread knowledge of
> WKContentView, and I don’t think it’s important in this case.

I made it a WKContentView because the view is passed through to another class which has WKContentView specific logic. If I changed it to a UIView here, I would need to cast to WKContentView later on. Do you prefer casting or keeping the definition as-is?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180723/8d3aa98c/attachment.html>

More information about the webkit-unassigned mailing list