[Webkit-unassigned] [Bug 187786] [WinCairo] Add missing piece for inspecting web inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187786

Fujii Hironori <Hironori.Fujii at sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #345292|review?                     |review-
              Flags|                            |

--- Comment #4 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 345292
  --> https://bugs.webkit.org/attachment.cgi?id=345292
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345292&action=review

> Source/cmake/OptionsWin.cmake:96
> +SET_AND_EXPOSE_TO_BUILD(ENABLE_DEVELOPER_MODE ${DEVELOPER_MODE})

I think you should define it in OptionsWinCairo.cmake to keep AppleWin port untouched.

> Tools/ChangeLog:3
> +        [WinCairo] Add missing piece for inspecting web inspector

What is the missing piece? I like more informative summary.

> ChangeLog:8
> +        * Source/cmake/OptionsWin.cmake:

This change needs a more informative change log entry.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180719/4c01e77c/attachment.html>