[Webkit-unassigned] [Bug 187741] [Datalist] Add button to TextFieldInputs with a datalist

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187741

--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 345203
  --> https://bugs.webkit.org/attachment.cgi?id=345203
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345203&action=review

> Source/WebCore/html/TextFieldInputType.cpp:322
> +#if ENABLE(DATALIST_ELEMENT)

This seems weird at a glance but I haven't read enough to know what's up.

> Source/WebCore/html/TextFieldInputType.cpp:883
> +    return (m_suggestionPicker != nullptr);

no need for all these characters, we don't usually do explicit comparisons with 0 (`return m_suggestionPicker` should be fine)

> Source/WebCore/rendering/RenderThemeMac.mm:262
> +    NSData *data = [[NSData alloc] initWithBase64EncodedString:@"iVBORw0KGgoAAAANSUhEUgAAAA4AAAAJCAYAAAACTR1pAAAABGdBTUEAALGPC/xhBQAAACBjSFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAABWWlUWHRYTUw6Y29tLmFkb2JlLnhtcAAAAAAAPHg6eG1wbWV0YSB4bWxuczp4PSJhZG9iZTpuczptZXRhLyIgeDp4bXB0az0iWE1QIENvcmUgNS40LjAiPgogICA8cmRmOlJERiB4bWxuczpyZGY9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkvMDIvMjItcmRmLXN5bnRheC1ucyMiPgogICAgICA8cmRmOkRlc2NyaXB0aW9uIHJkZjphYm91dD0iIgogICAgICAgICAgICB4bWxuczp0aWZmPSJodHRwOi8vbnMuYWRvYmUuY29tL3RpZmYvMS4wLyI+CiAgICAgICAgIDx0aWZmOk9yaWVudGF0aW9uPjE8L3RpZmY6T3JpZW50YXRpb24+CiAgICAgIDwvcmRmOkRlc2NyaXB0aW9uPgogICA8L3JkZjpSREY+CjwveDp4bXBtZXRhPgpMwidZAAAAr0lEQVQoFYWOMQrCUBBEfwhomSqtkNoL6An0WLmHZzB4Au0VrBUsbW0sbFJ838Rd+H4iLkxmdnbmkxBj3IEnWIc/Q2Zl2S4geqB5geWvLreFZaDYq9hK2TzgeV6WB3TzaVUswMYd+A5mXpY2DxpG2WK4I0qwHezP5wrVhkvid+jSH/XyBHOfhE7oY7If0NOvki8cKnAG+cirPDfKBPSLt6QpXY+Gc5NgY2WVmvyu/Q2JwxWVRuNg0wAAAABJRU5ErkJggg==" options:NSDataBase64DecodingIgnoreUnknownCharacters];

It seems like there's a bunch of leaks here.

But also, I don't love the inline image data.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180717/7630c0ed/attachment.html>