[Webkit-unassigned] [Bug 187737] TestWTF.WTF_Expected.Unexpected is not MSVC-safe

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187737

--- Comment #2 from JF Bastien <jfbastien at apple.com> ---
(In reply to Ross Kirsling from comment #1)
> (In reply to Ross Kirsling from comment #0)
> > ...due to the fact that MSVC evidently keeps a separate string for each
> > const char* variable when they're declared constexpr:
> > https://godbolt.org/g/HGC8nw
> 
> Dunno why this link isn't working -- I made another one here:
> https://godbolt.org/g/Bbwngz
> 
> As a solution, we could drop constexpr, add const, or use a value of a type
> other than const char*, but I want to make sure we're not losing some
> important coverage in doing so. JF, what would you prefer?

This is a test of constexpr. Dropping constexpr defeats the purpose of the test. When I compile your second link with /O1 I get two identical functions. Seems like an MSVC bug? This is comparing the const char * pointers held in the unexpected object, they really should be the same.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180717/a78ad8c0/attachment.html>