[Webkit-unassigned] [Bug 187639] [GLIB] Add API to evaluate code using a given object to store global symbols

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 14 11:49:31 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=187639

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com
 Attachment #345034|review?                     |review+
              Flags|                            |

--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 345034
  --> https://bugs.webkit.org/attachment.cgi?id=345034
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345034&action=review

> Source/JavaScriptCore/API/glib/JSCContext.cpp:775
> + * in @uri; the value is one-based so the first line is 1. @uri and @line_number will be shown in exceptions,
> + * they don't affect the behavior of the script.

This is a comma splice (in the last sentence). You know by now your options for how to fix it.

> Source/JavaScriptCore/API/glib/JSCContext.cpp:793
> + * jsc_context_evaluate_in_object:

It's confusing that this function always creates the object that evaluates the JS. Would it not be useful to be able to pass an existing object?

> Source/JavaScriptCore/ChangeLog:9
> +        evaluated script are added as propertuies to the new object instead of to the context global object. This is

properties

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180714/d67d4f45/attachment-0001.html>


More information about the webkit-unassigned mailing list