[Webkit-unassigned] [Bug 187531] [WinCairo] Add windows storage process connection implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187531

--- Comment #3 from Christopher Reid <chris.reid at sony.com> ---
(In reply to Fujii Hironori from comment #2)
> Comment on attachment 344722 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=344722&action=review
> 
> I'm not a reviewer. This is an informal review.
> 
> > Source/WebKit/StorageProcess/StorageProcess.cpp:268
> > +        return;
> 
> I think you shouldn't ignore this error. Mac port is calling LOG_ERROR and
> CRASH in case of error. Windows port should do the same.

It looks like the NetworkProcess::createNetworkConnectionToWebProcess also suppressed that error. I'll update that too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180711/9b707ec2/attachment.html>