[Webkit-unassigned] [Bug 186841] [WPE] Pass the backend library name as command line parameter to the web process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186841

--- Comment #17 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Zan Dobersek from comment #14)
> Comment on attachment 344682 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=344682&action=review
> 
> > Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:106
> > +#if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(0, 2, 0)
> > +        wpeBackendLibraryParameter.reset(g_strdup_printf("--backend-library=%s", wpe_loader_get_loaded_implementation_library_name()));
> > +#endif
> 
> Do we need the --backend-library flag?

Comment #8

"Yes, probably, I'm trying to avoid passing other stuff to wpe loader if we mess it up with the order of the arguments."

I can remove it if you don't like it.

> > Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:137
> > +        argv[i++] = wpeBackendLibraryParameter ? wpeBackendLibraryParameter.get() : "-";
> 
> I don't think wpeBackendLibraryParameter can be null if you use
> g_strdup_printf()? Unless we can remove the --backend-library flag and just
> strdup the impl library name, if any.

It can be nullptr when building with previous versions of WPEBackend.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180710/6b37f56c/attachment.html>