[Webkit-unassigned] [Bug 186841] [WPE] Pass the backend library name as command line parameter to the web process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186841

--- Comment #12 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 344677
  --> https://bugs.webkit.org/attachment.cgi?id=344677
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344677&action=review

> Source/WebKit/WebProcess/wpe/WebProcessMainWPE.cpp:74
> +#if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(0, 2, 0)
> +        if (argc > 4) {
> +            static const unsigned parameterLength = strlen("--backend-library=");
> +            if (!strncmp(argv[4], "--backend-library=", parameterLength))
> +                wpe_loader_init(argv[4] + parameterLength);
> +        }
> +#endif

Like discussed, IMO this should use '-' as a token when no library is specified. The token would be placed before the WPE fd, and the argc should be strictly 5 in value.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180710/1c104082/attachment.html>