[Webkit-unassigned] [Bug 187363] iPad: Scrolling with hardware keyboard while SELECT popover is visible scrolls the page, detaches popover

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187363

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thorton at apple.com
 Attachment #344368|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 344368
  --> https://bugs.webkit.org/attachment.cgi?id=344368
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344368&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3686
> +    if (_assistedNodeInformation.elementType != InputType::Select) {

I don't think this is quite right, because pageup/pagedown and spacebar will still scroll.

Instead, I think you should bail at the top of the function similar to what we do in the isContentEditable case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180705/4dcdafce/attachment-0001.html>