[Webkit-unassigned] [Bug 187212] [macOS] Don't treat URL titles as URLs when adding to the pasteboard

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187212

--- Comment #26 from Darin Adler <darin at apple.com> ---
Comment on attachment 344273
  --> https://bugs.webkit.org/attachment.cgi?id=344273
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344273&action=review

>>> Source/WebCore/platform/PlatformPasteboard.h:88
>>> +    WEBCORE_EXPORT long setPasteboardURL(const PasteboardURL&);
>> 
>> I don’t think having the word "Pasteboard" in this function makes sense. The entire file is about pasteboard, so why have this one function mention Pasteboard
> 
> I named it setPasteboardURL due to the parameter type. I feel that 'setURL' would not be correct as a URL is not the only information that is contained within a PasteboardURL - we also have the title.

Sure, but due to overloading C++ functions don’t always have to mention their parameter types. I am not suggesting setURL as the name. In fact there are no other "set" functions in this class, only "set for type" functions. I am not even sure I understand the difference between this function and the write function that takes a PasteboardURL.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180705/e4f7ee27/attachment-0001.html>