[Webkit-unassigned] [Bug 187288] [GTK][WPE] Add --host option to WebDriver process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187288

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 344173
  --> https://bugs.webkit.org/attachment.cgi?id=344173
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344173&action=review

Thanks!

>> Source/WebDriver/HTTPServer.h:60
>> +    bool listen(std::optional<String> host, unsigned port);
> 
> Nit: it's not that crucial here, but const reference to the std::optional object could be used to avoid copying the object on each call to listen() as well as the soupServerListen() helper.

Ok.

>> Source/WebDriver/soup/HTTPServerSoup.cpp:46
>> +        g_set_error(error, G_IO_ERROR, G_IO_ERROR_INVALID_ARGUMENT, "Invalid host IP address '%s'", host.value().utf8().data());
> 
> Nit: not necessarily an IP address.

It only works with IP addresses, you can't use a domain name.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180705/086eed39/attachment.html>