[Webkit-unassigned] [Bug 187264] REGRESSION(r233325): [GTK] Broke 40 animations tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 4 06:06:24 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=187264

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #5)
> Comment on attachment 344275 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=344275&action=review
> 
> LGTM but I think it needs to be run past Miguel or Zan.
> 
> Do we now have two display refresh monitors running while in AC mode?

No, the GTK one is destroyed when entering AC.

> > Source/WebCore/platform/graphics/gtk/DisplayRefreshMonitorGtk.cpp:62
> > +        m_window = gtk_offscreen_window_new();
> 
> I assume you've checked to ensure that you don't need to sink the ref.

It's a toplevel.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180704/cf557474/attachment-0001.html>


More information about the webkit-unassigned mailing list