[Webkit-unassigned] [Bug 187264] REGRESSION(r233325): [GTK] Broke 40 animations tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 3 06:34:08 PDT 2018


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
                 CC|                            |cgarcia at igalia.com,
                   |                            |zan at falconsigh.net

--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
This is because DocumentAnimationScheduler uses DisplayRefreshMonitor, that is only used by GTK port when accelerated compositing is enabled. Tests work if AC is forced, and fail if AC is disabled or even on demand. In the case of being on demand it fails because it expects a monitor refresh before entering AC mode. I'm not sure how to solve this, though in the case of on demand AC. I've added a DisplayRefreshMonitorGtk to be used when not in AC mode and it works, but I think it conflicts with the threaded refresh display monitor created by the threaded compositor when entering AC. It seems to work, but it's probably inefficient. So, maybe we could try to enter AC whenever DocumentAnimationScheduler tries to create a display refresh monitor. Another option could be to destroy the GTK refresh monitor when entering AC.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180703/21f263ff/attachment.html>

More information about the webkit-unassigned mailing list