[Webkit-unassigned] [Bug 187167] [WinCairo] WebKit MiniBrowser crashes when attempting to navigate to certain URLs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 2 14:35:15 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=187167

--- Comment #8 from Christopher Reid <chris.reid at sony.com> ---
(In reply to Anders Carlsson from comment #6)
> Comment on attachment 343896 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=343896&action=review
> 
> > Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:62
> > -    return adoptWK(WKStringCreateWithUTF8CString(utf8.c_str()));
> > +    return adoptWK(WKStringCreateWithUTF8CString(utf8.data()));
> 
> Pretty sure WKStringCreateWithUTF8CString expects a null terminated string.

I think that's okay, toUtf8() is null terminating the buffer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180702/430b18c5/attachment.html>


More information about the webkit-unassigned mailing list