[Webkit-unassigned] [Bug 187264] REGRESSION(r233325): [GTK] Broke 40 animations tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187264

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com

--- Comment #1 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Affected tests:

webkit.org/b/187264 animations/transition-and-animation-2.html [ Failure ]
webkit.org/b/187264 imported/w3c/web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-context.html [ Failure ]
webkit.org/b/187264 imported/w3c/web-platform-tests/web-animations/interfaces/Animation/cancel.html [ Failure ]
webkit.org/b/187264 imported/w3c/web-platform-tests/web-animations/interfaces/Animation/pause.html [ Failure ]
webkit.org/b/187264 imported/w3c/web-platform-tests/web-animations/interfaces/Animation/pending.html [ Failure ]
webkit.org/b/187264 imported/w3c/web-platform-tests/web-animations/interfaces/Animation/play.html [ Failure ]
webkit.org/b/187264 imported/w3c/web-platform-tests/web-animations/interfaces/Animation/playbackRate.html [ Failure ]
webkit.org/b/187264 imported/w3c/web-platform-tests/web-animations/interfaces/Animation/ready.html [ Failure ]
webkit.org/b/187264 imported/w3c/web-platform-tests/web-animations/interfaces/Animation/startTime.html [ Failure ]
webkit.org/b/187264 imported/w3c/web-platform-tests/web-animations/interfaces/AnimationEffectTiming/duration.html [ Failure ]
webkit.org/b/187264 imported/w3c/web-platform-tests/web-animations/timing-model/animations/canceling-an-animation.html [ Failure ]
webkit.org/b/187264 imported/w3c/web-platform-tests/web-animations/timing-model/animations/pausing-an-animation.html [ Failure ]
webkit.org/b/187264 imported/w3c/web-platform-tests/web-animations/timing-model/animations/playing-an-animation.html [ Failure ]
webkit.org/b/187264 imported/w3c/web-platform-tests/web-animations/timing-model/animations/reversing-an-animation.html [ Failure ]
webkit.org/b/187264 imported/w3c/web-platform-tests/web-animations/timing-model/animations/set-the-target-effect-of-an-animation.html [ Failure ]
webkit.org/b/187264 imported/w3c/web-platform-tests/web-animations/timing-model/animations/set-the-timeline-of-an-animation.html [ Failure ]
webkit.org/b/187264 imported/w3c/web-platform-tests/web-animations/timing-model/timelines/document-timelines.html [ Failure ]
webkit.org/b/187264 compositing/animation/layer-for-filling-animation.html [ Timeout ]
webkit.org/b/187264 imported/mozilla/css-animations/test_animation-cancel.html [ Timeout ]
webkit.org/b/187264 imported/mozilla/css-animations/test_animation-computed-timing.html [ Timeout ]
webkit.org/b/187264 imported/mozilla/css-animations/test_animation-currenttime.html [ Timeout ]
webkit.org/b/187264 imported/mozilla/css-animations/test_animation-finish.html [ Timeout ]
webkit.org/b/187264 imported/mozilla/css-animations/test_animation-pausing.html [ Timeout ]
webkit.org/b/187264 imported/mozilla/css-animations/test_animation-ready.html [ Timeout ]
webkit.org/b/187264 imported/mozilla/css-animations/test_animation-starttime.html [ Timeout ]
webkit.org/b/187264 imported/mozilla/css-animations/test_setting-effect.html [ Timeout ]
webkit.org/b/187264 imported/mozilla/css-transitions/test_animation-cancel.html [ Timeout ]
webkit.org/b/187264 imported/mozilla/css-transitions/test_animation-computed-timing.html [ Timeout ]
webkit.org/b/187264 imported/mozilla/css-transitions/test_animation-currenttime.html [ Timeout ]
webkit.org/b/187264 imported/mozilla/css-transitions/test_animation-pausing.html [ Timeout ]
webkit.org/b/187264 imported/mozilla/css-transitions/test_animation-ready.html [ Timeout ]
webkit.org/b/187264 imported/mozilla/css-transitions/test_animation-starttime.html [ Timeout ]
webkit.org/b/187264 imported/mozilla/css-transitions/test_event-dispatch.html [ Timeout ]
webkit.org/b/187264 imported/mozilla/css-transitions/test_setting-effect.html [ Timeout ]
webkit.org/b/187264 transitions/move-after-transition.html [ Timeout ]
webkit.org/b/187264 webanimations/opacity-animation-yields-compositing-span.html [ Timeout ]
webkit.org/b/187264 webanimations/opacity-animation-yields-compositing.html [ Timeout ]

Of these, all but two are timeouts (the other failures are timeouts not registered with the test runner).

animations/transition-and-animation-2.html has a weird text diff:

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/animations/transition-and-animation-2-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/animations/transition-and-animation-2-actual.txt
@@ -1,3 +1,3 @@
 This test has a transition and animation on the same property (-webkit-transform). The animation starts and then the transition is triggered. The transition should start at the position before the animation started (the unanimated position), which is (0,0). If it starts from the start point of the animation (0,100) then there is an error
-PASS - "webkitTransform.5" property for "box" element at 0.4s saw something close to: 0
+FAIL - "webkitTransform.5" property for "box" element at 0.4s expected: 0 but saw: matrix(1, 0, 0, 1, 0, 100)

It almost looks unrelated, but the only animations-related commit within the range where it started failing is r233325, so I'll mark it against this bug.

Then imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-no-browsing-context.html started to fail with this diff:

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-no-browsing-context-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-no-browsing-context-actual.txt
@@ -1,6 +1,6 @@

 PASS Element.animate() creates an animation with the correct timeline when called on an element in a document without a browsing context 
 PASS The timeline associated with an animation trigger on an element in a document without a browsing context is inactive 
-FAIL Replacing the timeline of an animation targetting an element in a document without a browsing context leaves it in the pending state assert_true: The animation should still be pending after replacing the document timeline expected true got false
+PASS Replacing the timeline of an animation targetting an element in a document without a browsing context leaves it in the pending state 
 PASS Replacing the timeline of an animation targetting an element in a document without a browsing context and then adopting that element causes it to start updating style 

I'll update our expectation for that test, since the PASS looks nicer than a FAIL to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180702/0dca1565/attachment-0001.html>