[Webkit-unassigned] [Bug 182326] Should chose the best match during 'route' if there are multiple matches.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 31 13:33:15 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=182326

--- Comment #3 from dewei_zhu at apple.com ---
Comment on attachment 332750
  --> https://bugs.webkit.org/attachment.cgi?id=332750
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332750&action=review

>> Websites/perf.webkit.org/public/v3/pages/page-router.js:43
>> +                } else if (hashUrl.startsWith(routeName) && hashUrl.charAt(routeName.length) == '/' && bestMatchingRouteName.length < routeName.length) {
> 
> What's hashUrl.charAt(routeName.length) == '/' about?

This check exists before. I would assume we want '/apple/xxxx' matches '/apple', and do not want it matches '/applepile/...'

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180131/dd178b8d/attachment-0001.html>


More information about the webkit-unassigned mailing list