[Webkit-unassigned] [Bug 182117] Lots of build warnings from Source/ThirdParty/openvr

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 30 14:15:00 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=182117

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com

--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Haven't tested, but I think something like this in Source/ThirdParty/openvr/CMakeLists.txt would do the trick:

if (COMPILER_IS_GCC_OR_CLANG)
    WEBKIT_ADD_TARGET_CXX_FLAGS(${LIBNAME} -Wno-implicit-fallthrough
                                           -Wno-parentheses
                                           -Wno-unknown-pragmas
                                           -Wno-unused-parameter
                                           -Wno-unused-variable)
endif ()

Should also remove the project() call in that file, as that's causing this warning:

CMake Warning (dev) at Source/ThirdParty/openvr/src/CMakeLists.txt:2 (project):
  Policy CMP0048 is not set: project() command manages VERSION variables.
  Run "cmake --help-policy CMP0048" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  The following variable(s) would be set to empty:

    PROJECT_VERSION
    PROJECT_VERSION_MAJOR
    PROJECT_VERSION_MINOR
This warning is for project developers.  Use -Wno-dev to suppress it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180130/706f8a8b/attachment-0001.html>


More information about the webkit-unassigned mailing list