[Webkit-unassigned] [Bug 182174] [GTK] Zooming gesture incorrectly uses scale instead of zoom

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 30 01:47:48 PST 2018


--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 332549
  --> https://bugs.webkit.org/attachment.cgi?id=332549
Patch changing scale to zoom - V3

View in context: https://bugs.webkit.org/attachment.cgi?id=332549&action=review

> Source/WebKit/UIProcess/gtk/GestureController.cpp:33
> +#include "WebKitWebView.h"

This is wrong. We shouldn't include WebKitWebView here, is kind of a layering violation, see below.

> Source/WebKit/UIProcess/gtk/GestureController.cpp:257
> +    webkit_web_view_set_zoom_level(WEBKIT_WEB_VIEW(m_page.viewWidget()), m_scale);

We can't assume viewWidget will be a WebKitWebView, it can be a WebKitWebViewBase. This will probably crash if you try to zoom the web inspector, for example. Anyway, I'll fix this as part of bug #182224.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180130/07efb9aa/attachment.html>

More information about the webkit-unassigned mailing list