[Webkit-unassigned] [Bug 182266] Should fetch owner commits in build-requests-fetcher.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 29 16:55:01 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=182266

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 332590
  --> https://bugs.webkit.org/attachment.cgi?id=332590
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332590&action=review

> Websites/perf.webkit.org/public/include/build-requests-fetcher.php:135
> +            if ($commit_owner_id && !array_key_exists($commit_owner_id, $this->commits_by_id))
> +                $commit_owners[$commit_owner_id] = TRUE;

Rather than manually finding owner commits like this, we should simply query the database as so:
SELECT * FROM commits, repositories WHERE commit_repository = repository_id AND commit_id
    IN (SELECT commitset_commit FROM commit_set_items WHERE commitset_set = $1);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180130/9d69b330/attachment.html>


More information about the webkit-unassigned mailing list