[Webkit-unassigned] [Bug 182157] [YarrJIT][ARM] We need to save r8 as it is the initial start register

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 29 11:02:39 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=182157

Saam Barati <sbarati at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #332334|review?                     |review+
              Flags|                            |

--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 332334
  --> https://bugs.webkit.org/attachment.cgi?id=332334
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332334&action=review

>>> Source/JavaScriptCore/ChangeLog:8
>>> +        We still need to keep on saving r6 as it is used by the MacroAssembler
>> 
>> you mean r8, not r6?
> 
> Sorry, I meant that in addition to saving $r8, as the title suggest, we can't stop saving $r6, as I initially wrongly deducted in a first version of the patch that was creating weird crashes :). My initial wrong deduction was because the initial register used to be $r6 before #182157.

Probably worth rewording this to reflect what the patch is actually doing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180129/f88cc4ed/attachment.html>


More information about the webkit-unassigned mailing list