[Webkit-unassigned] [Bug 160547] Overflow of formulas is hidden for display mathematics
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jan 28 14:53:39 PST 2018
https://bugs.webkit.org/show_bug.cgi?id=160547
--- Comment #13 from Minsheng Liu <lambda at liu.ms> ---
All resolved. line-height is set because inline math with line height = 1 will make div to have an extra 4px vertically. I have added a comment for that. 2 seconds delay is a leftover during my debug process and has been removed.
(In reply to Frédéric Wang (:fredw) from comment #11)
> Comment on attachment 332493 [details]
> patch
>
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=332493&action=review
>
> LGTM, but please be sure to address the review comments. Thanks!
>
> > LayoutTests/mathml/presentation/math-inline-display-width.html:25
> > + }, "dnline math, 100px content, 200px container");
>
> s/dnline/display/
>
> > LayoutTests/mathml/presentation/math-inline-display-width.html:43
> > + overflow: auto;
>
> maybe you want "overflow: hidden" so that you don't have any potential
> problem with scroll bars.
>
> > LayoutTests/mathml/presentation/math-inline-display-width.html:45
> > + line-height: 0;
>
> why this line-height property?
>
> > LayoutTests/mathml/presentation/math-inline-display-width.html:49
> > + <body onload="setTimeout(run, 2000)">
>
> why do you need this 2 seconds delay?
>
> > Source/WebCore/rendering/mathml/RenderMathMLMath.cpp:48
> > + LayoutUnit centerBlockOffset = std::max<LayoutUnit>(0, logicalWidth() - contentWidth) / 2;
>
> As I said in previous review, I think this can just be centerBlockOffset =
> (logicalWidth() - contentWidth) / 2; since contentWidth < logicalWidth().
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180128/c6b3d659/attachment-0001.html>
More information about the webkit-unassigned
mailing list