[Webkit-unassigned] [Bug 182224] [GTK] contextMenuEvent is NULL on CONTEXT_MENU call

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 28 14:18:49 PST 2018


Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #332492|commit-queue?               |commit-queue-
              Flags|                            |

--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 332492
  --> https://bugs.webkit.org/attachment.cgi?id=332492
Patch fixing contextMenuEvent

View in context: https://bugs.webkit.org/attachment.cgi?id=332492&action=review

We need to update the documentation of WebKitWebView::context-menu as well, to indicate that event may now be a GdkEventTouch of type GDK_TOUCH_END. (It would be GDK_TOUCH_END, right?)

Then I'll ask Carlos Garcia to do the final review, because this could in theory break applications depending on the assumptions they make about the type of the GdkEvent... I'd like to do this anyway, since I think it will be fine in practice.

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:936
> +        priv->contextMenuEvent.reset(gdk_event_copy(touchEvent));

Ah, that was easier than I expected.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180128/2bd314e0/attachment.html>

More information about the webkit-unassigned mailing list