[Webkit-unassigned] [Bug 182174] [GTK] Zooming gesture incorrectly uses scale instead of zoom
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 26 10:42:27 PST 2018
https://bugs.webkit.org/show_bug.cgi?id=182174
Michael Catanzaro <mcatanzaro at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mcatanzaro at igalia.com
--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 332382
--> https://bugs.webkit.org/attachment.cgi?id=332382
Patch changing scale to zoom
View in context: https://bugs.webkit.org/attachment.cgi?id=332382&action=review
> Source/WebKit/UIProcess/gtk/GestureController.cpp:258
> + g_object_notify(G_OBJECT(m_page.viewWidget()), "zoom-level");
Notifying for another object's property feels pretty fragile. I guess if it's the only place outside WebKitWebView where the zoom level needs to be changed, it's not the end of the world. But can you use webkit_web_view_set_zoom_level() instead? Then the gesture would additionally respect the text-only zoom setting.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180126/3140b9ef/attachment-0001.html>
More information about the webkit-unassigned
mailing list