[Webkit-unassigned] [Bug 182117] New: Lots of build warnings from Source/ThirdParty/openvr

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 25 11:36:36 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=182117

            Bug ID: 182117
           Summary: Lots of build warnings from Source/ThirdParty/openvr
           Product: WebKit
           Version: Other
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com
                CC: bugs-noreply at webkitgtk.org, svillar at igalia.com

I'm seeing a bunch of build warnings from Source/ThirdParty/openvr with GCC 7.2.1. The build should remain warning-free on all of the compilers we use. Most of these look like old warnings that should occur with any compiler version.

Since it's third-party code, it's usually best to disable the warnings in the CMakeLists.txt by using WEBKIT_ADD_TARGET_CXX_FLAGS. Alternatively, the code code be modified to suppress the warnings.

[119/2518] Building CXX object Source/...api.dir/vrcommon/dirtools_public.cpp.o
In file included from ../../Source/ThirdParty/openvr/src/vrcommon/dirtools_public.cpp:3:0:
../../Source/ThirdParty/openvr/src/vrcommon/strtools_public.h: In function ‘void wcsncpy_s(wchar_t*, size_t, const wchar_t*, size_t)’:
../../Source/ThirdParty/openvr/src/vrcommon/strtools_public.h:72:99: warning: unused parameter ‘count’ [-Wunused-parameter]
 inline void wcsncpy_s(wchar_t *strDest, size_t numberOfElements, const wchar_t *strSource, size_t count)
                                                                                                   ^~~~~
../../Source/ThirdParty/openvr/src/vrcommon/strtools_public.h: In function ‘void strncpy_s(char*, size_t, const char*, size_t)’:
../../Source/ThirdParty/openvr/src/vrcommon/strtools_public.h:78:93: warning: unused parameter ‘count’ [-Wunused-parameter]
 inline void strncpy_s(char *strDest, size_t numberOfElements, const char *strSource, size_t count)
                                                                                             ^~~~~
[120/2518] Building CXX object Source/...openvr_api.dir/openvr_api_public.cpp.o
In file included from ../../Source/ThirdParty/openvr/src/openvr_api_public.cpp:9:0:
../../Source/ThirdParty/openvr/src/../src/vrcommon/vrpathregistry_public.h:10:20: warning: ‘k_pchLogOverrideVar’ defined but not used [-Wunused-variable]
 static const char *k_pchLogOverrideVar = "VR_LOG_PATH";
                    ^~~~~~~~~~~~~~~~~~~
../../Source/ThirdParty/openvr/src/../src/vrcommon/vrpathregistry_public.h:9:20: warning: ‘k_pchConfigOverrideVar’ defined but not used [-Wunused-variable]
 static const char *k_pchConfigOverrideVar = "VR_CONFIG_PATH";
                    ^~~~~~~~~~~~~~~~~~~~~~
../../Source/ThirdParty/openvr/src/../src/vrcommon/vrpathregistry_public.h:8:20: warning: ‘k_pchRuntimeOverrideVar’ defined but not used [-Wunused-variable]
 static const char *k_pchRuntimeOverrideVar = "VR_OVERRIDE";
                    ^~~~~~~~~~~~~~~~~~~~~~~
[127/2518] Building CXX object Source/...pi.dir/vrcommon/pathtools_public.cpp.o
In file included from ../../Source/ThirdParty/openvr/src/vrcommon/pathtools_public.cpp:2:0:
../../Source/ThirdParty/openvr/src/vrcommon/strtools_public.h: In function ‘void wcsncpy_s(wchar_t*, size_t, const wchar_t*, size_t)’:
../../Source/ThirdParty/openvr/src/vrcommon/strtools_public.h:72:99: warning: unused parameter ‘count’ [-Wunused-parameter]
 inline void wcsncpy_s(wchar_t *strDest, size_t numberOfElements, const wchar_t *strSource, size_t count)
                                                                                                   ^~~~~
../../Source/ThirdParty/openvr/src/vrcommon/strtools_public.h: In function ‘void strncpy_s(char*, size_t, const char*, size_t)’:
../../Source/ThirdParty/openvr/src/vrcommon/strtools_public.h:78:93: warning: unused parameter ‘count’ [-Wunused-parameter]
 inline void strncpy_s(char *strDest, size_t numberOfElements, const char *strSource, size_t count)
                                                                                             ^~~~~
../../Source/ThirdParty/openvr/src/vrcommon/pathtools_public.cpp: In function ‘bool Path_IsAppBundle(const string&)’:
../../Source/ThirdParty/openvr/src/vrcommon/pathtools_public.cpp:464:44: warning: unused parameter ‘sPath’ [-Wunused-parameter]
 bool Path_IsAppBundle( const std::string & sPath )
                                            ^~~~~
../../Source/ThirdParty/openvr/src/vrcommon/pathtools_public.cpp: In function ‘bool Path_WriteBinaryFile(const string&, unsigned char*, unsigned int)’:
../../Source/ThirdParty/openvr/src/vrcommon/pathtools_public.cpp:658:23: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
        return written = nSize ? true : false;
               ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
[137/2518] Building CXX object Source/...api.dir/vrcommon/strtools_public.cpp.o
In file included from ../../Source/ThirdParty/openvr/src/vrcommon/strtools_public.cpp:2:0:
../../Source/ThirdParty/openvr/src/vrcommon/strtools_public.h: In function ‘void wcsncpy_s(wchar_t*, size_t, const wchar_t*, size_t)’:
../../Source/ThirdParty/openvr/src/vrcommon/strtools_public.h:72:99: warning: unused parameter ‘count’ [-Wunused-parameter]
 inline void wcsncpy_s(wchar_t *strDest, size_t numberOfElements, const wchar_t *strSource, size_t count)
                                                                                                   ^~~~~
../../Source/ThirdParty/openvr/src/vrcommon/strtools_public.h: In function ‘void strncpy_s(char*, size_t, const char*, size_t)’:
../../Source/ThirdParty/openvr/src/vrcommon/strtools_public.h:78:93: warning: unused parameter ‘count’ [-Wunused-parameter]
 inline void strncpy_s(char *strDest, size_t numberOfElements, const char *strSource, size_t count)
                                                                                             ^~~~~
[140/2518] Building CXX object Source/...r/vrcommon/vrpathregistry_public.cpp.o
In file included from ../../Source/ThirdParty/openvr/src/vrcommon/vrpathregistry_public.cpp:7:0:
../../Source/ThirdParty/openvr/src/vrcommon/strtools_public.h: In function ‘void wcsncpy_s(wchar_t*, size_t, const wchar_t*, size_t)’:
../../Source/ThirdParty/openvr/src/vrcommon/strtools_public.h:72:99: warning: unused parameter ‘count’ [-Wunused-parameter]
 inline void wcsncpy_s(wchar_t *strDest, size_t numberOfElements, const wchar_t *strSource, size_t count)
                                                                                                   ^~~~~
../../Source/ThirdParty/openvr/src/vrcommon/strtools_public.h: In function ‘void strncpy_s(char*, size_t, const char*, size_t)’:
../../Source/ThirdParty/openvr/src/vrcommon/strtools_public.h:78:93: warning: unused parameter ‘count’ [-Wunused-parameter]
 inline void strncpy_s(char *strDest, size_t numberOfElements, const char *strSource, size_t count)
                                                                                             ^~~~~
[149/2518] Building CXX object Source/...MakeFiles/openvr_api.dir/jsoncpp.cpp.o
../../Source/ThirdParty/openvr/src/jsoncpp.cpp:2459:0: warning: ignoring #pragma warning  [-Wunknown-pragmas]
 #pragma warning (push)

../../Source/ThirdParty/openvr/src/jsoncpp.cpp:2460:0: warning: ignoring #pragma warning  [-Wunknown-pragmas]
 #pragma warning (disable: 4702)

../../Source/ThirdParty/openvr/src/jsoncpp.cpp:4029:0: warning: ignoring #pragma warning  [-Wunknown-pragmas]
 #pragma warning (pop)

../../Source/ThirdParty/openvr/src/jsoncpp.cpp: In member function ‘bool Json::OurReader::readToken(Json::OurReader::Token&)’:
../../Source/ThirdParty/openvr/src/jsoncpp.cpp:1430:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
     if (features_.allowSingleQuotes_) {
     ^~
../../Source/ThirdParty/openvr/src/jsoncpp.cpp:1435:3: note: here
   case '/':
   ^~~~

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180125/c7295a46/attachment-0001.html>


More information about the webkit-unassigned mailing list