[Webkit-unassigned] [Bug 181996] [GTK] Page crash after swipe gesture running GNOME3 under wayland

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 24 08:26:17 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=181996

--- Comment #12 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 332167
  --> https://bugs.webkit.org/attachment.cgi?id=332167
Add GDK_TOUCH_CANCEL support - V2

View in context: https://bugs.webkit.org/attachment.cgi?id=332167&action=review

Remaining nits:

> Source/WebKit/ChangeLog:2
> +2018-01-24  Jan-Michael Brummer  <jan.brummer at tabos.org>
> +        [GTK] Page crash after swipe gesture running GNOME3 under wayland

There should be a blank line here.

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:71
>  #include <wtf/text/CString.h>
> +#include <wtf/Compiler.h>

I'm surprised 'webkit-patch upload' didn't spit warnings at you about this... uppercase letters sort before lowercase letters, so if you used that command you would have gotten an alphabetization warning here. Normally Bugzilla complains too, but maybe it only looks at the patch if you set the r? flag.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180124/10578c02/attachment-0001.html>


More information about the webkit-unassigned mailing list