[Webkit-unassigned] [Bug 181967] Fix CommitSet.equals bug which will always return false when comparing CommitSet against MeasurementCommitSet.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 24 00:45:35 PST 2018
https://bugs.webkit.org/show_bug.cgi?id=181967
--- Comment #6 from dewei_zhu at apple.com ---
Comment on attachment 332005
--> https://bugs.webkit.org/attachment.cgi?id=332005
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=332005&action=review
>>> Websites/perf.webkit.org/public/v3/models/commit-set.js:119
>>> +
>>
>> We shouldn't have this special branch as I mentioned earlier. r- because of this.
>
> Sure. Then, we need to repeat below for loop, but loop against other._repositoryToCommitMap instead. Otherwise, this function will give us a incorrect return if 'this' is some sort of subset of 'other'.
Never mind. As we've already checked the size of repositories.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180124/99349b2d/attachment-0001.html>
More information about the webkit-unassigned
mailing list