[Webkit-unassigned] [Bug 181986] [CMake][GTK] OpenGL support should be disabled if only EGL is found

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 23 10:42:35 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=181986

--- Comment #3 from Adrian Perez <aperez at igalia.com> ---
(In reply to Michael Catanzaro from comment #2)
> (In reply to Adrian Perez from comment #0)
> > If a system has an EGL implementation, but it's not possible to find
> > a libGL, libGLES, or libepoxy, then CMake should disable all the WebKit
> > features which depend on OpenGL.
> 
> I don't think so; OpenGL is an important feature and it should never be
> automagically disabled. The only way that should ever happen is if the user
> passes -DENABLE_OPENGL=OFF at configure time. The current code allows OpenGL
> to be automagically replaced with OpenGLES, but it does not allow for both
> to be automagically disabled.

Indeed, and I agree that we have to keep enabling OpenGL by default,
and only disabling it if explicitly requested. As a matter of fact, I
will be submitting a patch for Buildroot which makes the build recipe
explicitly pass “-DENABLE_OPENGL=OFF” when no OpenGL (ES) is available,
plus showing a warning during configuration.

> And, if -DENABLE_OPENGL=OFF was passed, this would not be a problem at all.
> So IMO the problem is that the error occurs too late, at build time instead
> of configure time. IMO CMake should fail the build when this situation is
> detected. I'm surprised that didn't happen; our find_package checks should
> already ensure that. Something must be wrong there.

Agreed. I think there has to be some gremlin in our CMake files. It's not
urgent to fix this, but it would be nice to fail early when CMake runs
instead of later on during compilation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180123/1a770100/attachment.html>


More information about the webkit-unassigned mailing list