[Webkit-unassigned] [Bug 181716] Parse calc() in CSS media queries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=181716

--- Comment #40 from Chris Nardi <christopherncarmel at hotmail.com> ---
(In reply to Antti Koivisto from comment #38)
> Comment on attachment 331872 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=331872&action=review
> 
> > Source/WebCore/css/MediaQueryExpression.cpp:40
> > +static inline bool featureWithValidIdent(const AtomicString& mediaFeature, const CSSPrimitiveValue* value)
> 
> 'const CSSPrimitiveValue&' would be better since the value is non-null.
> RefPtr has operator* so invoking with 'featureWithValidIdent(m_mediaFeature,
> *firstValue)' works.
> 
> > Source/WebCore/css/MediaQueryExpression.cpp:58
> > +static inline bool featureWithValidDensity(const String& mediaFeature, const CSSPrimitiveValue* value)
> 
> Also here.
> 
> > Source/WebCore/css/MediaQueryExpression.cpp:68
> > +static inline bool featureWithValidPositiveLength(const String& mediaFeature, const CSSPrimitiveValue* value)
> 
> And here
> 
> > Source/WebCore/css/MediaQueryExpression.cpp:100
> > +static inline bool featureWithPositiveInteger(const String& mediaFeature, const CSSPrimitiveValue* value)
> 
> And here
> 
> > Source/WebCore/css/MediaQueryExpression.cpp:121
> > +static inline bool featureWithZeroOrOne(const String& mediaFeature, const CSSPrimitiveValue* value)
> 
> And here

Done for all of those changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180122/b51d60b8/attachment.html>