[Webkit-unassigned] [Bug 181716] Parse calc() in CSS media queries

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 22 00:09:39 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=181716

Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #331872|review?                     |review+
              Flags|                            |

--- Comment #38 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 331872
  --> https://bugs.webkit.org/attachment.cgi?id=331872
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331872&action=review

> Source/WebCore/css/MediaQueryExpression.cpp:40
> +static inline bool featureWithValidIdent(const AtomicString& mediaFeature, const CSSPrimitiveValue* value)

'const CSSPrimitiveValue&' would be better since the value is non-null. RefPtr has operator* so invoking with 'featureWithValidIdent(m_mediaFeature, *firstValue)' works.

> Source/WebCore/css/MediaQueryExpression.cpp:58
> +static inline bool featureWithValidDensity(const String& mediaFeature, const CSSPrimitiveValue* value)

Also here.

> Source/WebCore/css/MediaQueryExpression.cpp:68
> +static inline bool featureWithValidPositiveLength(const String& mediaFeature, const CSSPrimitiveValue* value)

And here

> Source/WebCore/css/MediaQueryExpression.cpp:100
> +static inline bool featureWithPositiveInteger(const String& mediaFeature, const CSSPrimitiveValue* value)

And here

> Source/WebCore/css/MediaQueryExpression.cpp:121
> +static inline bool featureWithZeroOrOne(const String& mediaFeature, const CSSPrimitiveValue* value)

And here

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180122/dd71baa9/attachment.html>


More information about the webkit-unassigned mailing list