[Webkit-unassigned] [Bug 181893] Should reject updating a build request which has an associated build.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 19 22:56:41 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=181893

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 331833
  --> https://bugs.webkit.org/attachment.cgi?id=331833
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331833&action=review

> Websites/perf.webkit.org/public/include/report-processor.php:146
> -            if ($this->db->update_row('build_requests', 'request', array('id' => $build_request_id), array('status' => 'completed', 'build' => $build_id))
> +            if ($this->db->update_row('build_requests', 'request', array('id' => $build_request_id, 'build' => null), array('status' => 'completed', 'build' => $build_id))

We need to this check before build row is created.

> Websites/perf.webkit.org/server-tests/api-report-tests.js:784
> +            assert.equal(response['status'], 'OK');
> +            return TestServer.remoteAPI().postJSON('/api/report/', [anotherReportWithSameBuildRequest]);

As I mentioned, we should check that this didn't create a new build entry.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180120/6c96e73c/attachment.html>


More information about the webkit-unassigned mailing list