[Webkit-unassigned] [Bug 176881] Layout Test plugins/js-from-destroy.html is flaky

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 19 16:29:59 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=176881

--- Comment #5 from Daniel Bates <dbates at webkit.org> ---
The cause of the flakiness is <https://trac.webkit.org/changeset/164015> (bug #128712).

We have not supported JavaScript evaluation from NPP_Destroy() on macOS for Out-of-Process plugins for many years now. We disallowed such behavior in <https://trac.webkit.org/changeset/42789> and <https://trac.webkit.org/changeset/62279> (bug #41431). We should make WebKit match the behavior the OOP plugins on macOS and then change the test plugins/js-from-destroy.html and others to ensure that we do not allow JavaScript evaluation from NPP_Destroy(). See bug #181889 for more details.

Additional remarks:

Plugin tests that evaluate JavaScript from NPP_Destroy() have been flaky in WebKit since <https://trac.webkit.org/changeset/164015> (bug #128712). Following r164015 when NPP_Destroy() is called there is a racy between the time the PluginProcess's response reaches the WebProcess and it invalidates the PluginProcess connection and the PluginProcess sends a synchronous message to the WebProcess to evaluate the JavaScript specified in the ondestroy handler of an <embed>. Depending on who wins the race the ondestroy handler may or may not be invoked => a console message may or may not be in the result for the test plugins/js-from-destroy.html.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180120/8e290a02/attachment.html>


More information about the webkit-unassigned mailing list